[#32064][prism] Keep elements heap in sequence order. #32065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
lostluck
changed the title
damondouglas
reviewed
Aug 2, 2024
| @@ -688,6 +697,7 @@ func reElementResiduals(residuals []Residual, inputInfo PColInfo, rb RunBundle) | |||
| pane: pn, | |||
| elmBytes: elmBytes, | |||
| keyBytes: keyBytes, | |||
| sequence: len(unprocessedElements), | |||
There was a problem hiding this comment.
Non-blocking. I know that len has an O(1) but just curious why not just for i, w := range ws { sequence: i }?
There was a problem hiding this comment.
Because that would be sequencing per window, (degenerate case, all 0) rather than by the whole residual set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sequence field to elements so that elements with the same timestamp, (and typically, in the same key and and from the same bundle), retain their order within a key.
This wouldn't be required if the sort in the heap package were stable, outside of the heap invariant.
The allows the Java validate runner PerKeyOrderingTests to pass.
Fixes #32064.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.