Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lineage metrics to FileSystems #32090
Add Lineage metrics to FileSystems #32090
Changes from 2 commits
cfd3e06
1c599d3
2e22db6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the relative path not possible here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For GCS there is a GcsPath that also handles relative path. GcsResourceId is a wrapper of it so in theory there is possibility encounter relative path, that's why I added a warning in GcsFileSystem.reportLineage.
Current codepath should never encounter relative gcs path in reportLineage as the resourceId parsed in are all matched result that was assembled from
GcsPath.fromObject(storageObject)
, where storageObject comes from List API call response, which then resolved to full path.For s3 FileSystem it's not possible. S3ResourceId stores the absolute path directly (there is no equivalent of GcsPath here). There is essentially single entrance to new an S3ResourceId object which is here:
beam/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3ResourceId.java
Line 76 in 1c599d3
and it explicitly add a "/" in key.