Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CsvIO]: Implement CsvIOParse::withCustomRecordParsing method #32142

Conversation

francisohara24
Copy link
Contributor

@francisohara24 francisohara24 commented Aug 9, 2024

This PR closes #31875.
It impements a method for adding and validating custom field mapped lambdas.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

francisohara24 and others added 3 commits August 9, 2024 00:22
Co-authored-by: Lahari Guduru <lahariguduru@google.com>
Co-authored-by: Lahari Guduru <lahariguduru@google.com>
Co-authored-by: Lahari Guduru <lahariguduru@google.com>
@francisohara24 francisohara24 changed the title [CsvIO]: Implement CsvIOParse.withCustomRecordParsing [CsvIO]: Implement CsvIOParse::withCustomRecordParsing Aug 9, 2024
@francisohara24 francisohara24 changed the title [CsvIO]: Implement CsvIOParse::withCustomRecordParsing [CsvIO]: Implement CsvIOParse::withCustomRecordParsing method Aug 9, 2024
@damondouglas damondouglas self-requested a review August 9, 2024 22:04
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahariguduru and @francisohara24 Good Job and thank you for all your contributions!

@damondouglas damondouglas merged commit fc5a71d into apache:master Aug 9, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CsvIO]: Implement CsvIOParse::withCustomrecordParsing method
2 participants