Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostCommit Python sklearn on Python3.12 #32171

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 13, 2024

Fix #30513

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Aug 14, 2024

Python3.12 PostCommit fixed

Python3.8 PostCommit failed with

:sdks:python:test-suites:portable:py38:portableLocalRunnerJuliaSetWithSetupPy

Python3.11 PostCommit failed

FAILED�[0m apache_beam/examples/complete/game/game_stats_it_test.py::GameStatsIT::test_game_stats_it

404 Not found: Table apache-beam-testing:game_stats_it_dataset17235839854cb2ff.game_stats_sessions was not found in location US

both not related to the change.

The sklearn tests now passed

@Abacn Abacn marked this pull request as ready for review August 14, 2024 15:09
@Abacn
Copy link
Contributor Author

Abacn commented Aug 14, 2024

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Aug 14, 2024

R: @tvalentyn

@Abacn Abacn merged commit 7af43ee into apache:master Aug 14, 2024
91 of 94 checks passed
@Abacn Abacn deleted the fixpostcommit branch August 14, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PostCommit Python job is flaky
2 participants