-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TextIO.read() split with non-default delimiter #32298
Conversation
02e4591
to
6d11a0f
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@@ -672,8 +672,8 @@ public void testReadStringsWithCustomDelimiter() throws Exception { | |||
"To be, or not to be: that |is the question: ", | |||
// incomplete delimiter | |||
"To be, or not to be: that *is the question: ", | |||
// complete delimiter | |||
"Whether 'tis nobler in the mind to suffer |*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we preserve this existing line case. just add one more line to test *||**|
, like
// complete delimiter
"Whether 'tis nobler in the mind to suffer |*",
// edge case: partial delimiter then complete delimiter
"The slings and arrows of outrageous fortune,*||**|"
// truncated delimiter
"Or to take arms against a sea of troubles,|"
6d11a0f
to
daa2b7f
Compare
Run Java_GCP_IO_Direct PreCommit |
Could you check #32251 (comment)? I think this PR cannot fix all the cases of the issue #32251. |
Resolves #32251
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.