Move PubsubIO source Lineage report to MapElements #32381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested PubsubIOReadIT on Dataflow legacy runner cc: @tomstepp |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Abacn
force-pushed
the
pubsublineagealt
branch
from
a441447
to
aa1b489
Compare
Abacn
force-pushed
the
pubsublineagealt
branch
from
aa1b489
to
0614c67
Compare
Abacn
commented
Sep 9, 2024
| @@ -72,18 +72,18 @@ private static String wrapSegment(String value) { | |||
| * | |||
| * <ul> | |||
| * <li>{@code system:segment1.segment2} | |||
| * <li>{@code system:routine:segment1.segment2} | |||
| * <li>{@code system:subtype:segment1.segment2} | |||
There was a problem hiding this comment.
also fix routine->subtype which is the official name of this part of FQN. I was confused by some internal doc which marked "routine" here
|
LGTM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received feedback of #32319 that the standalone Impulse->DoFn lineage reporting may be confusing as user sees an extra transform while expanding PubSubIO read in their UI
This PR moves Lineage report into the existing MapElement step, using a wrapper SerializableFunction. In this way job graph is unchanged.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.