-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized SparkRunner ParDo Operation #32546
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Thanks for the change. I saw several changes of Spark runner improvement this PR and #32610 . If you are looking for reviewer a suggestion here is to send an email to beam devlist (https://lists.apache.org/list.html?dev@beam.apache.org) introducing these changes and ask people who are familiar with Beam Spark Runner for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, just had a minor comment
By any chance is it able to test the performance diff?
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/TransformTranslator.java
Show resolved
Hide resolved
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/TransformTranslator.java
Show resolved
Hide resolved
…slation/TransformTranslator.java
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/TransformTranslator.java
Outdated
Show resolved
Hide resolved
…slation/TransformTranslator.java
@Abacn |
Please add a meaningful description for your change here
fixes #32537
This PR contains these changes
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.