Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized SparkRunner ParDo Operation #32546

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

twosom
Copy link
Contributor

@twosom twosom commented Sep 24, 2024

Please add a meaningful description for your change here

fixes #32537

This PR contains these changes

  • optimized to skip filter operation when there is only single output
  • add related test

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added build and removed build labels Sep 25, 2024
@github-actions github-actions bot added build and removed build labels Sep 25, 2024
@github-actions github-actions bot added build and removed build labels Sep 25, 2024
@Abacn
Copy link
Contributor

Abacn commented Oct 1, 2024

Thanks for the change. I saw several changes of Spark runner improvement this PR and #32610 . If you are looking for reviewer a suggestion here is to send an email to beam devlist (https://lists.apache.org/list.html?dev@beam.apache.org) introducing these changes and ask people who are familiar with Beam Spark Runner for review

@github-actions github-actions bot added build and removed build labels Oct 2, 2024
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just had a minor comment

By any chance is it able to test the performance diff?

@github-actions github-actions bot added build and removed build labels Oct 2, 2024
@github-actions github-actions bot added the build label Oct 2, 2024
@github-actions github-actions bot removed the build label Oct 2, 2024
@Abacn Abacn merged commit 3f76d11 into apache:master Oct 3, 2024
20 checks passed
@twosom
Copy link
Contributor Author

twosom commented Oct 3, 2024

thanks, just had a minor comment

By any chance is it able to test the performance diff?

@Abacn
I tested it on a 40GB DNA dataset.
It's a pipeline that simply counts the number of DNA elements.
Firstly, the DAG is less verbose because it's stripped of unnecessary filters.
In terms of performance, unfortunately, I didn't see a dramatic change at 40GB, which I don't think you'll notice unless you're working with very large datasets, as it simply removes redundant filter operations.
(It did have a slight effect though).
In the picture, the left side is the pipeline after this PR, and the right side is the old pipeline.

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Optimize Spark Runner parDo transform evaluator
2 participants