-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GlobalWindows to be encoded as IntervalWindows #32569
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3d31687
Try to repro failure
damccorm 3a472e0
More suites
damccorm 65e3825
Got the repro
damccorm 948eb33
Simpler repro of problem
damccorm 280691b
Fix coder issues
damccorm fed480e
clean up equals
damccorm e2705dd
fully translate back
damccorm 8e76e1a
revert setup changes
damccorm a67a9d8
Add hash function
damccorm e76d4c6
use member functions instead of inheritance
damccorm 674d3ca
ssmall fix
damccorm 67c8349
fix to_global_window
damccorm 4e0ad87
return type
damccorm 82a05fe
lint
damccorm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ | |
from parameterized import parameterized | ||
from parameterized import parameterized_class | ||
|
||
import apache_beam as beam | ||
from apache_beam.utils import windowed_value | ||
from apache_beam.utils.timestamp import Timestamp | ||
|
||
|
@@ -75,6 +76,22 @@ def test_pickle(self): | |
wv = windowed_value.WindowedValue(1, 3, (), pane_info) | ||
self.assertTrue(pickle.loads(pickle.dumps(wv)) == wv) | ||
|
||
def test_encoding_global_window_in_interval_window(self): | ||
input_data = ['123'] | ||
|
||
class ComputeWordLengthFn(beam.DoFn): | ||
def process(self, element): | ||
pass | ||
|
||
def finish_bundle(self): | ||
yield beam.transforms.window.GlobalWindows.windowed_value('test') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One should only emit to windows that were part of the input. |
||
|
||
with beam.Pipeline() as p: | ||
_ = ( | ||
p | 'create' >> beam.Create(input_data) | ||
| beam.WindowInto(beam.transforms.window.FixedWindows(10)) | ||
| beam.ParDo(ComputeWordLengthFn())) | ||
|
||
|
||
WINDOWED_BATCH_INSTANCES = [ | ||
windowed_value.HomogeneousWindowedBatch.of( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be checking this at every element encoding; instead lift the import.