Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info log between executing work failed and cleanup #32570

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 26, 2024

We've seen (internal bug: 367930654) pipeline stuck at closing reader indefinitely, but it is not obvious from worker log, apparently straggler detector does not work for closeReader.

This log is added so that worker log will print the actual cause of Exception before conducting clean up steps (e.g. closeReader for source, etc)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Sep 26, 2024

Java PreCommit failing testPubsubSinkOverride due to #32465 , not related to this change. opened a revert PR at #32572

@Abacn Abacn merged commit 7c565c3 into apache:master Sep 26, 2024
15 of 16 checks passed
@Abacn Abacn deleted the printmsg branch September 26, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants