Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counter metrics for ParDo#with_exception_handling(timeout). #32571

Merged

Conversation

claudevdm
Copy link
Contributor

@claudevdm claudevdm commented Sep 26, 2024

Make parent thread state sampler available in child thread when running ParDo#with_exception_handling(timeout).

  • ParDo#with_exception_handling(timeout) executes the DoFn in a new thread [1]
  • Incrimenting a counter invokes tries to access the state sampler that was declared in the main thread local storage from the child thread [2]
  • Since the child thread does not have access to the state sampler from the main thread the get_current_tracker method fails silently [3] and the counter isnt actually incremented

This change makes the parent thread's state sampler available to the child thread.

[1]

return self._pool.submit(

[2]
_STATE_SAMPLERS = threading.local()

[3]


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm claudevdm changed the title Make parent thread state sampler available in child thread when runni… Fix counter metrics for ParDo#with_exception_handling(timeout). Sep 26, 2024
…ng ParDo#with_exception_handling(timeout).
@claudevdm claudevdm force-pushed the exception-with-timeout-tracker-wrapper branch from 661209f to e31e742 Compare October 2, 2024 16:59
@claudevdm claudevdm marked this pull request as ready for review October 3, 2024 18:48
@tvalentyn tvalentyn merged commit 0a71499 into apache:master Oct 3, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants