Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pubsub topic validation #32582

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

proost
Copy link
Contributor

@proost proost commented Sep 27, 2024

Please add a meaningful description for your change here

fix: #18027

adding validation to check topic exist or not for PubsubIO

previous PR validation is default. But this disable default.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.85%. Comparing base (160dffd) to head (ad9c053).
Report is 186 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java 81.25% 6 Missing and 3 partials ⚠️
...pache/beam/sdk/io/gcp/pubsub/PubsubGrpcClient.java 71.42% 1 Missing and 1 partial ⚠️
...pache/beam/sdk/io/gcp/pubsub/PubsubJsonClient.java 66.66% 1 Missing and 1 partial ⚠️
...pache/beam/sdk/io/gcp/pubsub/PubsubTestClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32582      +/-   ##
============================================
+ Coverage     57.32%   58.85%   +1.53%     
- Complexity     1474     3091    +1617     
============================================
  Files           967     1130     +163     
  Lines        153754   174117   +20363     
  Branches       1076     3328    +2252     
============================================
+ Hits          88140   102480   +14340     
- Misses        63410    68297    +4887     
- Partials       2204     3340    +1136     
Flag Coverage Δ
java 69.89% <77.41%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Reminder, please take a look at this pr: @Abacn @johnjcasey

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles @damondouglas

@kennknowles
Copy link
Member

R: @ahmedabu98

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the issue in the last attempt

@ahmedabu98 ahmedabu98 merged commit 3b9d86d into apache:master Oct 17, 2024
23 checks passed
@proost proost deleted the feat-pubsub-topic-validation branch October 18, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate Pubsub Topic exists when reading
3 participants