Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Python SDK Distroless variant #33160

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Nov 19, 2024

Addresses #32817 adding Python SDK (non-ML) distroless variant. Future PR will add a GitHub workflow to run checks.

Before submitting this PR, the following tests passed:

:sdks:python:test-suites:dataflow:py39:validatesDistrolessContainer
:sdks:python:test-suites:dataflow:py310:validatesDistrolessContainer
:sdks:python:test-suites:dataflow:py311:validatesDistrolessContainer
:sdks:python:test-suites:dataflow:py312:validatesDistrolessContainer

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review November 19, 2024 01:11
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping
Copy link
Contributor

Thanks! Could you also trigger the workflow of beam_PostCommit_Python? Trying to make sure it won't break that post commit again. ;)

@github-actions github-actions bot added build and removed build labels Nov 19, 2024
@github-actions github-actions bot added the build label Nov 19, 2024
@damondouglas
Copy link
Contributor Author

R: @Abacn

@github-actions github-actions bot removed the build label Nov 19, 2024
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

exec {
def testTarget = "apache_beam/examples/wordcount_it_test.py::WordCountIT::test_wordcount_it"
def argMap = [
"output" : "gs://temp-storage-for-end-to-end-tests/py-it-cloud/output",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally the temp location and project to run the test should be configurable. However I checked in Java SDK's gradle files it is the case, but not for python SDK's gradle files, so it is fine for now

@damondouglas damondouglas merged commit fc9083b into apache:master Nov 20, 2024
96 checks passed
@damondouglas damondouglas deleted the distroless-python-sdk branch November 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants