Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Iceberg support for name-based mapping schema #33315

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add Iceberg support for name-based mapping schema #33315

merged 5 commits into from
Jan 7, 2025
+244 −10

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Dec 6, 2024

Fixes #33314

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@regadas regadas force-pushed the fix_ice_namemapping branch from dcedd33 to f5a0764 Compare December 9, 2024 10:39
@regadas regadas mentioned this pull request Dec 9, 2024
Closed
17 tasks
@regadas regadas force-pushed the fix_ice_namemapping branch from f5a0764 to 2b4ff68 Compare December 9, 2024 10:55
@regadas regadas marked this pull request as ready for review December 9, 2024 10:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@regadas
Copy link
Contributor Author

regadas commented Dec 9, 2024

assign set of reviewers

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions GitHub Actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn @Abacn

@regadas
Copy link
Contributor Author

regadas commented Dec 19, 2024

cc @ahmedabu98; I'll rebase soon

ahmedabu98
ahmedabu98 reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, it might be worth calling out in CHANGES.MD

sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/ScanTaskReader.java Show resolved Hide resolved
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/IcebergIOReadTest.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@ahmedabu98
Copy link
Contributor

waiting on author

@regadas regadas force-pushed the fix_ice_namemapping branch from 2b4ff68 to 2f0f04b Compare January 6, 2025 22:32
@regadas regadas force-pushed the fix_ice_namemapping branch from 239aaa7 to 5fdc3ff Compare January 6, 2025 22:45
@github-actions github-actions bot added the build label Jan 6, 2025
@github-actions github-actions bot removed the build label Jan 6, 2025
@regadas
Copy link
Contributor Author

regadas commented Jan 6, 2025

Hi @ahmedabu98 can you take another look? thx 🙏

ahmedabu98
ahmedabu98 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahmedabu98 ahmedabu98 merged commit 40151ab into apache:master Jan 7, 2025
22 checks passed
jrmccluskey pushed a commit to jrmccluskey/beam that referenced this pull request Jan 8, 2025
@regadas @jrmccluskey
Add Iceberg support for name-based mapping schema (apache#33315)
1faaef0 
* Add Iceberg support for name-based mapping schema

* Add nullable annotation

* Add nested field

* iceberg-gcp already as a runtimeOnly

* Trigger IT tests
claudevdm pushed a commit to claudevdm/beam that referenced this pull request Jan 10, 2025
Revert "Add Iceberg support for name-based mapping schema (apache#33315…
899dd4d 
…)"

This reverts commit 40151ab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedabu98 ahmedabu98 ahmedabu98 approved these changes

Assignees
No one assigned
Labels
io java Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: IcebergIO support name-based mapping for a schema
2 participants
@regadas @ahmedabu98