[BEAM-143] add test for UnboundedSourceWrapper #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, we initialize the UnboundedSourceReader at runtime which requires us to keep a copy of the PipelineOptions. This should be fine here because we are at the lowest point of the execution stack.
The test ensures serialization and execution of the wrapper works as expected.
| * | ||
| *</p> | ||
| * For now we support non-parallel, not checkpointed sources. | ||
| * For now we only support non-parallel sources. | ||
| * */ | ||
| public class UnboundedSourceWrapper<T> extends RichSourceFunction<WindowedValue<T>> implements Triggerable { |
There was a problem hiding this comment.
It looks like this is a wrapper for Read.Unbounded not UnboundedSource -- maybe should rename to UnboundedReadWrapper? (Or ReadUnboundedWrapper)?
There was a problem hiding this comment.
I think it really is a wrapper for UnboundedSource. In my view Read.Unbounded is just the API construct that itself contains an UnboundedSource. Said source is then handled by the UnboundedSourceWrapper at runtime.
|
Peppered a few comments, but looks great to me. Glad to have the chance to get my eyes on some Flink code! |
|
er, +1 |
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
…riptors apache#61 [euphoria-flink] Do not hold states in memory
ryucc
added a commit
to ryucc/beam
that referenced
this pull request
Feb 1, 2023
Update version to 2.45.1
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the
UnboundedSourceWrapperhas not been tested systematically which led to a bunch of regression issues. This PR fixes the UnboundedSourceWrapper and adds a test case. The test case ensures that the wrapper works as expected. In particular, a full integration test is run to check whether serialization and instantiation of the wrapper works in a cluster setup.