Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6263] Fix error-prone test setup for FlinkJobServerDriver #7309

Merged
merged 4 commits into from
Dec 19, 2018

Conversation

mxm
Copy link
Contributor

@mxm mxm commented Dec 18, 2018

Please see the four commits which address different issues with the test setup:

  • [BEAM-6263] Prevent NullPointer on concurrent JobServer shutdown
  • [BEAM-6263] Prevent port collisions in FlinkJobServerDriveTest
  • [BEAM-6263] Prevent stderr->stdout redirection
  • [BEAM-6263] Restore stderr on exceptions to print the error

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@mxm mxm requested a review from angoenka December 18, 2018 18:24
@mxm
Copy link
Contributor Author

mxm commented Dec 19, 2018

Unrelated test failure: 20:00:05 Execution failed for task ':beam-sdks-java-io-hadoop-format:test'.

@mxm
Copy link
Contributor Author

mxm commented Dec 19, 2018

Filed https://issues.apache.org/jira/browse/BEAM-6268 Alexey is working on a fix.

All other tests pass. Will merge because this fixes crucial testing issues which even led the error messages being hidden from the test results.

@mxm mxm merged commit 302b883 into apache:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant