Fix several byte / unicode issues for Python 3 #7665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python PostCommit |
| @@ -226,7 +226,7 @@ def read_meta_data_from_file(f): | |||
| meta = header['meta'] | |||
|
|
|||
| if datafile.CODEC_KEY in meta: | |||
| codec = meta[datafile.CODEC_KEY] | |||
| codec = meta[datafile.CODEC_KEY].decode('utf-8') | |||
There was a problem hiding this comment.
When running the avroio tests in Python 3, this results in the following error for me:
File "/home/robbe/workspace/beam/sdks/python/apache_beam/io/avroio.py", line 355, in _decompress_bytes
raise ValueError('Unknown codec: %r' % codec)
ValueError: Unknown codec: 'null'
I've used another approach and have fixed all but 2 Python 3 errors in avroio. see #7644.
There was a problem hiding this comment.
Approach in #7644 makes sense to me. Once merged - @charlesccychen PTAL if you still encounter the errors and rebase the PR on top of master. Thank you.
| @@ -1046,7 +1046,7 @@ def byte_array_to_json_string(raw_bytes): | |||
| @staticmethod | |||
| def json_string_to_byte_array(encoded_string): | |||
| """Implements org.apache.beam.sdk.util.StringUtils.jsonStringToByteArray.""" | |||
| return unquote(encoded_string) | |||
| return unquote(encoded_string).encode('utf-8') | |||
There was a problem hiding this comment.
PR #7650 also contains a fix for this, using unquote_to_bytes(), instead of importing
from future.moves.urllib.parse import quote
from future.moves.urllib.parse import unquote
so the code is 'Python 3 native'.
There was a problem hiding this comment.
Thanks for your comments @RobbeSneyders. Let's use unquote_to_bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes some compatibility issues with running on Python 3.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)