Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6569] Remove a flaky test from a precommit suite. #7691

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Jan 31, 2019

Remove a flaky on Python 3 apache_beam.io.gcp.gcsio_test from a Python 3 precommit suite.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Jan 31, 2019

CCing a few commiters who can merge this, one review is enough. @aaltay @charlesccychen @mxm @robertwb @pabloem

@tvalentyn
Copy link
Contributor Author

cc: @RobbeSneyders, @Juta, @markflyhigh as FYI.

@pabloem
Copy link
Member

pabloem commented Jan 31, 2019

You can check that apache_beam.io.gcp.gcsio_test appears elsewhere on the list (closer to the begining).

…pache_beam.io.hdfs_integration_test, apache_beam.io.range_trackers_test, and once again apache_beam.io.gcp.gcsio_test.
@tvalentyn
Copy link
Contributor Author

Good catch, thanks, @pabloem.

@pabloem
Copy link
Member

pabloem commented Jan 31, 2019

Happy to merge once tests pass.

@tvalentyn
Copy link
Contributor Author

This is ready to merge. Thank you.

@pabloem pabloem merged commit 41091cb into apache:master Jan 31, 2019
wscheep pushed a commit to wscheep/beam that referenced this pull request Feb 2, 2019
* [BEAM-6569] Remove a flaky test from a precommit suite.

* Remove duplicate mentions of apache_beam.io.gcp.gcsfilesystem_test, apache_beam.io.hdfs_integration_test, apache_beam.io.range_trackers_test, and once again apache_beam.io.gcp.gcsio_test.
@tvalentyn tvalentyn deleted the patch-34 branch October 23, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants