[6571] Windmill service flag #7693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
WindmillServiceFlag to fix conflict
drieber
reviewed
Feb 5, 2019
...cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java
Show resolved
Hide resolved
| String STREAMING_ENGINE_EXPERIMENT = "enable_streaming_engine"; | ||
|
|
||
| /** @deprecated Use STREAMING_ENGINE_EXPERIMENT instead. */ | ||
| @Deprecated String WINDMILL_SERVICE_EXPERIMENT = "enable_windmill_service"; |
...dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
Show resolved
Hide resolved
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Run Java_Examples_Dataflow PreCommit |
|
Run Spotless PreCommit |
drieber
reviewed
Feb 5, 2019
...dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
Outdated
Show resolved
Hide resolved
drieber
reviewed
Feb 5, 2019
|
Run Spotless PreCommit |
|
Run Java PreCommit |
|
Run Python PreCommit |
aaltay
reviewed
Feb 6, 2019
|
Running a sample job gives (abrieviated):
which is correct for now as "Windmill Service requires (Dataflow or Beam) Java SDK >= 2.8.0". It still seems good to keep the flags in sync though so leaving the python flag in for now. |
aaltay
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the flag --enableStreamingEngine to Java and Python. Setting this flag turns on the correct experiments to enable streaming engine on the back end.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)