[BEAM-6577] Examine func return types when generating shims #7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starcgenx.Extractor should examine both function input and output when extracting types from a package. Otherwise, the generated code may miss certain package imports.
lostluck
reviewed
Feb 4, 2019
| in := sig.Params() // *types.Tuple | ||
| for i := 0; i < in.Len(); i++ { | ||
| s := in.At(i) // *types.Var | ||
| for _, tuple := range []*types.Tuple{sig.Params(), sig.Results()} { |
There was a problem hiding this comment.
I'm not a fan of expanding this one indentation deeper.
Consider moving the inside of the loop to a new function "extractFromTuple"
and then just calling it on both the Params and the Results.
Similarly, extractParameters, should be renamed to extractFromSignature
This matches the structure of the types in the go/types package, which makes it easier to customize further if necessary.
There was a problem hiding this comment.
Thanks for the comments! Refactored accordingly.
Rename extractParameters to extractFromSignature, which calls extractFromTuple using both params and results.
htyleo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starcgenx.Extractor should examine both function input and output when extracting types from a package. Otherwise, the generated code may miss certain package imports.
R: @lostluck
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)