Fix BigQuery RowAsDictJsonCoder output type in Python 3 #7727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @tvalentyn @aaltay |
aaltay
approved these changes
Feb 5, 2019
|
Run Python Postcommit |
|
Run Python PostCommit |
|
Run Python Postcommit |
tvalentyn
approved these changes
Feb 5, 2019
|
Run Python Postcommit |
|
Run Portable_Python PreCommit |
|
Run Python PreCommit |
charlesccychen
force-pushed
the
fix-bq-coder
branch
from
a3f75b5
to
65c9759
Compare
tvalentyn
reviewed
Feb 5, 2019
| except ValueError as e: | ||
| raise ValueError('%s. %s' % (e, JSON_COMPLIANCE_ERROR)) | ||
|
|
||
| def decode(self, encoded_table_row): | ||
| return json.loads(encoded_table_row) | ||
| return json.loads(encoded_table_row.decode('utf-8')) |
There was a problem hiding this comment.
Could you please check that this works with Tornadoes example on DirectRunner?
There was a problem hiding this comment.
Yes, this continues to work with both DirectRunner and DataflowRunner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the BigQuery tornadoes example pipeline to run on Dataflow with Python 3.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)