Got rid of reference to windmill_service_streaming_rpc_batching experiment #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory on the windmill_service_streaming_rpc_batching experiment. That experiment is now fully rolled out.
|
R: @dpmills (sorry, I messed up while trying to rebase PR/7705, so decided to start from scratch here) |
|
R: @aaltay |
|
R: @dustin12 |
|
Run Java PreCommit |
|
Run JavaPortabilityApi PreCommit |
dustin12
reviewed
Feb 5, 2019
...ain/java/org/apache/beam/runners/dataflow/worker/options/StreamingDataflowWorkerOptions.java
Outdated
Show resolved
Hide resolved
|
LGTM |
|
LGTM. Python precommit error is unrelated, the change is a Java only change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to predicate WindmillServiceStreamingRpcBatchLimitFactory on the windmill_service_streaming_rpc_batching experiment. That experiment is now fully rolled out.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)