Fix a bug in use of no_use_multiple_sdk_containers experiment flag. #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting this flag should prevent the addition of use_multiple_sdk_containers experiment.
ajamato
approved these changes
Feb 6, 2019
| @@ -356,6 +356,34 @@ def test_labels(self): | |||
| self.assertEqual('key5', job.proto.labels.additionalProperties[4].key) | |||
| self.assertEqual('', job.proto.labels.additionalProperties[4].value) | |||
|
|
|||
| def test_experiment_use_multiple_sdk_containers(self): | |||
| pipeline_options = PipelineOptions( | |||
There was a problem hiding this comment.
Is it possible to actually fail the pipeline if the experiments are invalid? Are we doing that? seems like the user was having issues getting the format correct. Just want to make sure we error out on invalid input
--experiment A,B . should fail. That was the pattern we saw
Also, do we print a good error message with proper sample input?
Please fix in this PR or add a TODO with a JIRA number.
There was a problem hiding this comment.
No we do not fail this out. But "A,B" might actually be a valid experiment. This case is unlikely, but one generally possible case for having commas in the experiment is --experiment A=B,C,D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in use of no_use_multiple_sdk_containers experiment flag.Setting this flag should prevent the addition of use_multiple_sdk_containers experiment.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)