State that Datastore IO is not supported in Streaming scenario. #7758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @aaltay |
Ardagan
changed the title
Ardagan
force-pushed
the
DatastoreIODocUpdate
branch
from
2fcf23f
to
9f9015a
Compare
aaltay
reviewed
Feb 7, 2019
| @@ -53,6 +53,9 @@ | |||
|
|
|||
| class ReadFromDatastore(PTransform): | |||
| """A ``PTransform`` for reading from Google Cloud Datastore. | |||
|
|
|||
There was a problem hiding this comment.
We can drop this change. Web site changes are sufficient. The reasons this notice is not consistent, there are other IOs that will not work in streaming mode and they do not have comments. It is also likely to not get updated as the support is added.
There was a problem hiding this comment.
I still feel that we should add such information to code base as well.
But concerned of two independent sources of truth that can go out of sync.
Ardagan
force-pushed
the
DatastoreIODocUpdate
branch
from
9f9015a
to
e95ca0b
Compare
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* Initial plumbing for collection group queries * Don't assume direct children for collection group queries. * trim document path to DocumentReference * add unit tests * ensure all_descendants is set after calling other query methods * port test for node impl * port tests from node impl * Fix collection group test on Python 2.7. Blacken. * Use '_all_descendants' in 'Query.__eq__'. * Ensure '_all_descendants' propagates when narrowing query. * Refactor collection group system tests. Skip the one for 'where', because it requires a custom index. * Match node test's collection group ID / expected output. See: https://github.com/googleapis/nodejs-firestore/pull/578/files#diff-6b8febc8d51ea01205628091b3611eacR1188 * Match Node test for filter on '__name__'. Note that this still doesn't pass, so remains skipped. * Blacken. * Fix / unskip systest for collection groups w/ filter on '__name__'. * Blacken * 100% coverage. * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users try to utilize Datastore IO with Python Streaming that is not supported.
Explicitly state in documentation that this scenario is not supported.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)