Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-2640: BP-43 Some clean up and making sure that all bookkeepr-se… #2692

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

pkumar-singh
Copy link
Member

@pkumar-singh pkumar-singh commented Apr 16, 2021

Motivation

Consolidate and ensure that at last all bookkeeper server test pass with gradle.
That essentially entails cleaning up direct dependencies.

Changes

% ./gradlew cleanTest bookkeeper-server:test

Configure project :microbenchmarks
0
<============-> 99% EXECUTING [2m 54s]
<============-> 99% EXECUTING [9m 52s]
:bookkeeper-server:test > 455 tests completed, 6 skipped
<============-> 99% EXECUTING [36m 52s]
:bookkeeper-server:test > 487 tests completed, 7 skipped
<============-> 99% EXECUTING [54m 24s]
<============-> 99% EXECUTING [54m 25s]ompleted, 16 skipped
<============-> 99% EXECUTING [1h 3m 16s]
<============-> 99% EXECUTING [1h 6m 39s]
:bookkeeper-server:test > 777 tests completed, 19 skippedeeper.replication.AuditorPeriodicCheckTest
:bookkeeper-server:test > Executing test org.apache.bookkeeper.replication.AuditorBookieTest
<============-> 99% EXECUTING [1h 14m 37s]
<============-> 99% EXECUTING [1h 14m 38s]leted, 19 skipped
<============-> 99% EXECUTING [1h 20m 59s]
<============-> 99% EXECUTING [1h 21m 0s]
:bookkeeper-server:test > Executing test org.apache.bookkeeper.client.BookKeeperAdminTest

I interrupted the tests after 777 tests after rebasing. But all the tests have passed before with same set of changes.

Master Issue: #2640

@merlimat merlimat added this to the 4.14.0 milestone Apr 20, 2021
Copy link
Contributor

@hsaputra hsaputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@hsaputra
Copy link
Contributor

Will merge this by EOD PST if no more comments or questions.
Thanks

@hsaputra hsaputra merged commit eb2443e into apache:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants