Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use class names to access static variables or methods #2829

Closed
wants to merge 2 commits into from
Closed

Use class names to access static variables or methods #2829

wants to merge 2 commits into from

Conversation

lordcheng10
Copy link
Contributor

Motivation

Accessing the static variables and methods of the class through the object reference of this class will increase the cost of the compiler's analysis. A better way is to directly use the class name to access the static variables or methods.

@lordcheng10
Accessing the static variables and methods of the class through the o…
6f123d0 
…bject reference of this class will increase the cost of the compiler's analysis. A better way is to directly use the class name to access the static variables or methods.
nicoloboschi
nicoloboschi approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lordcheng10
Copy link
Contributor Author

@dlg99 PTAL , thanks!

@lordcheng10
Copy link
Contributor Author

rerun failed checks

5 similar comments
@lordcheng10
Copy link
Contributor Author

rerun failed checks

@lordcheng10
Copy link
Contributor Author

rerun failed checks

@lordcheng10
Copy link
Contributor Author

rerun failed checks

@lordcheng10
Copy link
Contributor Author

rerun failed checks

@lordcheng10
Copy link
Contributor Author

rerun failed checks

@dlg99
Copy link
Contributor

dlg99 commented Oct 15, 2021

tests are failing with

Execution failed for task ':bookkeeper-common:compileTestJava'.
> Could not resolve all files for configuration ':bookkeeper-common:testCompileClasspath'.
   > Could not find log4j:log4j:1.2.27.

which is probably something caused by #2816 nd gradle changes colliding
@RaulGracia @pkumar-singh can you take a look at this?

@pkumar-singh
Copy link
Member

pkumar-singh commented Oct 15, 2021 •
edited
Loading

This PR from @RaulGracia #2816 should have fixed it. Kindly check @dlg99

@lordcheng10
Copy link
Contributor Author

lordcheng10 commented Oct 15, 2021 •
edited
Loading

This PR from @RaulGracia #2816 should have fixed it. Kindly check @dlg99

@dlg99 @pkumar-singh Thanks for your attention, I merge the master code into my branch and try again。

@lordcheng10
Copy link
Contributor Author

@hsaputra PTAL , thanks!

@lordcheng10
Copy link
Contributor Author

PTAL,thanks! @dlg99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lordcheng10 @dlg99 @pkumar-singh @nicoloboschi