Allocator support exitOnOutOfMemory config. #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@horizonzy Please fix the check style, thanks. |
hangc0276
requested review from
merlimat,
Vanlightly,
hangc0276,
dlg99,
eolivelli,
shoothzj and
zymap
|
@lhotari Please help take a look, thanks. |
|
The ci failed. Fixing it now. |
done |
|
rerun failure checks |
shoothzj
requested changes
May 5, 2024
StevenLuMT
approved these changes
Jul 13, 2024
| */ | ||
| @Slf4j | ||
| public class ShutdownUtil { | ||
| private static final Method log4j2ShutdownMethod; |
There was a problem hiding this comment.
I have a question, this is copied from pulsar-common directly, why not import pulsar-common in bookkeeper/bookkeeper-common-allocator/pom.xml
There was a problem hiding this comment.
Except for the ShutdownUtil problem, the rest are pretty good,LGTM @horizonzy
There was a problem hiding this comment.
It's a minor import, we needn't import new dependency.
shoothzj
approved these changes
Jul 13, 2024
please fix the checkstyle issue, thanks @horizonzy
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
In some cases, if the process can't allocate memory, we would better exit the JVM, or the bookie can't serve, and the client always timeout.
Add config
allocatorExitOnOutOfMemory. When the allocator encounters oom, exit the JVM.