Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baidu_rpc协议能否一次RPC调用创建多个Stream #2733

Closed
jenrryyou opened this issue Aug 9, 2024 · 3 comments · Fixed by #2754
Closed

baidu_rpc协议能否一次RPC调用创建多个Stream #2733

jenrryyou opened this issue Aug 9, 2024 · 3 comments · Fixed by #2754

Comments

@jenrryyou
Copy link
Contributor

我们的场景需要创建比较多的Stream，为了提升性能和稳定性，想给baidu_rpc 增加一次RPC批量创建多个stream的能力，目前的想法是StreamCreate，StreamAccept都支持传入StreamIds，同时Controller里_request_stream和_response_stream也都改成数组。其他的接口保持不变，streaming_rpc_meta.proto里会增加一个批量的StreamSettings，协议保持兼容（新旧版本可以共用）。最近准备开发了，想问下社区有什么建议吗？
@chenBright
Copy link
Contributor

新服务端不知道客户端是怎么建流的，所以只能用批量的StreamAccept了吧？

@jenrryyou
Copy link
Contributor Author

对，按传过来的StreamIds的顺序批量accept，返回streamID顺序也会传入的StreamID对应

@jenrryyou jenrryyou mentioned this issue Sep 2, 2024
Merged
@chenBright chenBright linked a pull request Sep 13, 2024 that will close this issue
Batch create and accept stream #2754
Merged
@jiushun
Copy link

jiushun commented Sep 17, 2024

如何在rpc的实现方法里，等待 stream 关闭后再返回response呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Batch create and accept stream jenrryyou/incubator-brpc
3 participants
@jenrryyou @chenBright @jiushun