-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch create and accept stream #2754
Conversation
看了下macos protobuf22 CI 编译的报错 但是也没有在编译时办法传入PROTOBUF_NO_THREADLOCAL宏,protobuf一个头文件做了检查,外部配置PROTOBUF_NO_THREADLOCAL宏就会报错 继续分析了下应该是protobuf的BUG,已经在MR protocolbuffers/protobuf#12983 修复, 但是protobuf@22.5版本没有包含该fix,导致在mac上只要在proto文件里使用repeated 类型的Field就会编译出错 |
LGTM |
有空帮忙点下merge,多谢 |
d85b4db
to
c881856
Compare
modify code based on the code review feedback and add more tests
c881856
to
58c392a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@chenBright @wwbmmm 大佬们有空帮忙点下merge |
What problem does this PR solve?
Issue Number: #2733
Problem Summary: 支持一次RPC调用创建多个流
Side effects:
Performance effects(性能影响):
对批量创建stream场景有性能提升
Breaking backward compatibility(向后兼容性):
协议改动兼容,支持平滑升级
Check List: