Fix the linkage errors caused by duplicate symbols #1936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I met some linkage errors while using
LLD
linker to compile the source code of Apache Doris. The issue looks like #1809 .src/butil/class_name.h
The linkage of
ClassNameHelper<T>::name
here is external due to it is variable template and it may cause the duplicate symbols error.Some ways to fix it:
inline variable
.ClassNameHelper<T>::name
internal.In this PR, I suggest using the second way to fix it.