add gflag to disable sampler thread #1990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #1891
Problem Summary: there is currently no gflag to control the switch of the sampler thread
What is changed and the side effects?
Changed: add
--bvar_enable_sampling
flag to control the switch of the sampler thread. if flag is false, does not create a global singleton SamplerCollector object.Side effects:
Performance effects(性能影响): setting the flag to false will reduce the creation of one thread and the usage of CPU and memory
Breaking backward compatibility(向后兼容性): yes
Check List: