Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gflag to disable sampler thread #1990

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

leaf-potato
Copy link
Contributor

What problem does this PR solve?

Issue Number: #1891

Problem Summary: there is currently no gflag to control the switch of the sampler thread

What is changed and the side effects?

Changed: add --bvar_enable_sampling flag to control the switch of the sampler thread. if flag is false, does not create a global singleton SamplerCollector object.

Side effects:

  • Performance effects(性能影响): setting the flag to false will reduce the creation of one thread and the usage of CPU and memory

  • Breaking backward compatibility(向后兼容性): yes


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Nov 14, 2022

LGTM

1 similar comment
@serverglen
Copy link
Contributor

LGTM

@serverglen serverglen merged commit 81b9397 into apache:master Nov 14, 2022
@leaf-potato leaf-potato deleted the sampler branch November 14, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants