apache · wwbmmm · Nov 21, 2022 · Nov 19, 2022 · Nov 19, 2022
diff --git a/example/asynchronous_echo_c++/server.cpp b/example/asynchronous_echo_c++/server.cpp
@@ -32,8 +32,8 @@ DEFINE_int32(logoff_ms, 2000, "Maximum duration of server's LOGOFF state "
 // Your implementation of example::EchoService
 class EchoServiceImpl : public example::EchoService {
 public:
-    EchoServiceImpl() {};
-    virtual ~EchoServiceImpl() {};
+    EchoServiceImpl() {}
+    virtual ~EchoServiceImpl() {}
     virtual void Echo(google::protobuf::RpcController* cntl_base,
                       const example::EchoRequest* request,
                       example::EchoResponse* response,

diff --git a/example/auto_concurrency_limiter/server.cpp b/example/auto_concurrency_limiter/server.cpp
@@ -93,7 +93,7 @@ class EchoServiceImpl : public test::EchoService {
         , _running_case(false) {
     };
 
-    virtual ~EchoServiceImpl() {};
+    virtual ~EchoServiceImpl() {}
 
     void SetTestCase(const test::TestCase& test_case) {
         _test_case = test_case;

diff --git a/example/backup_request_c++/server.cpp b/example/backup_request_c++/server.cpp
@@ -37,8 +37,8 @@ namespace example {
 class SleepyEchoService : public EchoService
                         , public brpc::Describable {
 public:
-    SleepyEchoService() : _count(0) {};
-    virtual ~SleepyEchoService() {};
+    SleepyEchoService() : _count(0) {}
+    virtual ~SleepyEchoService() {}
     virtual void Echo(google::protobuf::RpcController* cntl_base,
                       const EchoRequest* request,
                       EchoResponse* response,

diff --git a/example/cancel_c++/server.cpp b/example/cancel_c++/server.cpp
@@ -35,8 +35,8 @@ DEFINE_int32(logoff_ms, 2000, "Maximum duration of server's LOGOFF state "
 namespace example {
 class EchoServiceImpl : public EchoService {
 public:
-    EchoServiceImpl() {};
-    virtual ~EchoServiceImpl() {};
+    EchoServiceImpl() {}
+    virtual ~EchoServiceImpl() {}
     virtual void Echo(google::protobuf::RpcController* cntl_base,
                       const EchoRequest* request,
                       EchoResponse* response,

diff --git a/example/cascade_echo_c++/server.cpp b/example/cascade_echo_c++/server.cpp
@@ -38,8 +38,8 @@ brpc::Channel channel;
 namespace example {
 class CascadeEchoService : public EchoService {
 public:
-    CascadeEchoService() {};
-    virtual ~CascadeEchoService() {};
+    CascadeEchoService() {}
+    virtual ~CascadeEchoService() {}
     virtual void Echo(google::protobuf::RpcController* cntl_base,
                       const EchoRequest* request,
                       EchoResponse* response,

diff --git a/example/dynamic_partition_echo_c++/server.cpp b/example/dynamic_partition_echo_c++/server.cpp
@@ -45,7 +45,7 @@ DEFINE_double(max_ratio, 10, "max_sleep / sleep_us");
 class EchoServiceImpl : public example::EchoService {
 public:
     EchoServiceImpl() : _index(0) {}
-    virtual ~EchoServiceImpl() {};
+    virtual ~EchoServiceImpl() {}
     void set_index(size_t index, int64_t sleep_us) { 
         _index = index; 
         _sleep_us = sleep_us;

diff --git a/example/echo_c++/server.cpp b/example/echo_c++/server.cpp
@@ -37,8 +37,8 @@ DEFINE_int32(logoff_ms, 2000, "Maximum duration of server's LOGOFF state "
 namespace example {
 class EchoServiceImpl : public EchoService {
 public:
-    EchoServiceImpl() {};
-    virtual ~EchoServiceImpl() {};
+    EchoServiceImpl() {}
+    virtual ~EchoServiceImpl() {}
     virtual void Echo(google::protobuf::RpcController* cntl_base,
                       const EchoRequest* request,
                       EchoResponse* response,

diff --git a/example/grpc_c++/server.cpp b/example/grpc_c++/server.cpp
@@ -32,8 +32,8 @@ DEFINE_bool(gzip, false, "compress body using gzip");
 
 class GreeterImpl : public helloworld::Greeter {
 public:
-    GreeterImpl() {};
-    virtual ~GreeterImpl() {};
+    GreeterImpl() {}
+    virtual ~GreeterImpl() {}
     void SayHello(google::protobuf::RpcController* cntl_base,
                  const helloworld::HelloRequest* req,
                  helloworld::HelloReply* res,

diff --git a/example/http_c++/http_server.cpp b/example/http_c++/http_server.cpp
@@ -38,8 +38,8 @@ namespace example {
 // Service with static path.
 class HttpServiceImpl : public HttpService {
 public:
-    HttpServiceImpl() {};
-    virtual ~HttpServiceImpl() {};
+    HttpServiceImpl() {}
+    virtual ~HttpServiceImpl() {}
     void Echo(google::protobuf::RpcController* cntl_base,
               const HttpRequest*,
               HttpResponse*,
@@ -66,8 +66,8 @@ class HttpServiceImpl : public HttpService {
 // Service with dynamic path.
 class FileServiceImpl : public FileService {
 public:
-    FileServiceImpl() {};
-    virtual ~FileServiceImpl() {};
+    FileServiceImpl() {}
+    virtual ~FileServiceImpl() {}
 
     struct Args {
         butil::intrusive_ptr<brpc::ProgressiveAttachment> pa;
@@ -116,8 +116,8 @@ class FileServiceImpl : public FileService {
 // when adding the service into server).
 class QueueServiceImpl : public example::QueueService {
 public:
-    QueueServiceImpl() {};
-    virtual ~QueueServiceImpl() {};
+    QueueServiceImpl() {}
+    virtual ~QueueServiceImpl() {}
     void start(google::protobuf::RpcController* cntl_base,
                const HttpRequest*,
                HttpResponse*,

diff --git a/example/multi_threaded_echo_c++/server.cpp b/example/multi_threaded_echo_c++/server.cpp
@@ -36,7 +36,7 @@ namespace example {
 class EchoServiceImpl : public EchoService {
 public:
     EchoServiceImpl() {}
-    ~EchoServiceImpl() {};
+    ~EchoServiceImpl() {}
     void Echo(google::protobuf::RpcController* cntl_base,
               const EchoRequest* request,
               EchoResponse* response,

diff --git a/example/multi_threaded_echo_fns_c++/server.cpp b/example/multi_threaded_echo_fns_c++/server.cpp
@@ -46,7 +46,7 @@ DEFINE_double(max_ratio, 10, "max_sleep / sleep_us");
 class EchoServiceImpl : public example::EchoService {
 public:
     EchoServiceImpl() : _index(0) {}
-    virtual ~EchoServiceImpl() {};
+    virtual ~EchoServiceImpl() {}
     void set_index(size_t index, int64_t sleep_us) { 
         _index = index; 
         _sleep_us = sleep_us;

diff --git a/example/nshead_pb_extension_c++/server.cpp b/example/nshead_pb_extension_c++/server.cpp
@@ -32,8 +32,8 @@ DEFINE_int32(idle_timeout_s, -1, "Connection will be closed if there is no "
 namespace example {
 class EchoServiceImpl : public EchoService {
 public:
-    EchoServiceImpl() {};
-    virtual ~EchoServiceImpl() {};
+    EchoServiceImpl() {}
+    virtual ~EchoServiceImpl() {}
     virtual void Echo(google::protobuf::RpcController*,
                       const EchoRequest* request,
                       EchoResponse* response,

diff --git a/example/parallel_echo_c++/server.cpp b/example/parallel_echo_c++/server.cpp
@@ -35,7 +35,7 @@ DEFINE_int32(max_concurrency, 0, "Limit of request processing in parallel");
 class EchoServiceImpl : public example::EchoService {
 public:
     EchoServiceImpl() {}
-    ~EchoServiceImpl() {};
+    ~EchoServiceImpl() {}
     void Echo(google::protobuf::RpcController* cntl_base,
               const example::EchoRequest* request,
               example::EchoResponse* response,

diff --git a/example/partition_echo_c++/server.cpp b/example/partition_echo_c++/server.cpp
@@ -45,7 +45,7 @@ DEFINE_double(max_ratio, 10, "max_sleep / sleep_us");
 class EchoServiceImpl : public example::EchoService {
 public:
     EchoServiceImpl() : _index(0) {}
-    virtual ~EchoServiceImpl() {};
+    virtual ~EchoServiceImpl() {}
     void set_index(size_t index, int64_t sleep_us) { 
         _index = index; 
         _sleep_us = sleep_us;

diff --git a/example/rdma_performance/server.cpp b/example/rdma_performance/server.cpp
@@ -32,7 +32,7 @@ namespace test {
 class PerfTestServiceImpl : public PerfTestService {
 public:
     PerfTestServiceImpl() {}
-    ~PerfTestServiceImpl() {};
+    ~PerfTestServiceImpl() {}
 
     void Test(google::protobuf::RpcController* cntl_base,
               const PerfTestRequest* request,

diff --git a/example/selective_echo_c++/server.cpp b/example/selective_echo_c++/server.cpp
@@ -44,7 +44,7 @@ DEFINE_double(max_ratio, 10, "max_sleep / sleep_us");
 class EchoServiceImpl : public example::EchoService {
 public:
     EchoServiceImpl() : _index(0) {}
-    virtual ~EchoServiceImpl() {};
+    virtual ~EchoServiceImpl() {}
     void set_index(size_t index, int64_t sleep_us) { 
         _index = index; 
         _sleep_us = sleep_us;

diff --git a/example/streaming_echo_c++/server.cpp b/example/streaming_echo_c++/server.cpp
@@ -54,7 +54,7 @@ class StreamReceiver : public brpc::StreamInputHandler {
 // Your implementation of example::EchoService
 class StreamingEchoService : public example::EchoService {
 public:
-    StreamingEchoService() : _sd(brpc::INVALID_STREAM_ID) {};
+    StreamingEchoService() : _sd(brpc::INVALID_STREAM_ID) {}
     virtual ~StreamingEchoService() {
         brpc::StreamClose(_sd);
     };

diff --git a/src/brpc/socket.h b/src/brpc/socket.h
@@ -64,7 +64,7 @@ class Stream;
 class SocketUser {
 public:
     virtual ~SocketUser() {}
-    virtual void BeforeRecycle(Socket*) {};
+    virtual void BeforeRecycle(Socket*) {}
 
     // Will be periodically called in a dedicated thread to check the
     // health.

diff --git a/src/brpc/thrift_message.h b/src/brpc/thrift_message.h
@@ -49,7 +49,7 @@ static const int16_t THRIFT_RESPONSE_FID = 0;
 //   from ThriftMessageBase which can be stored and handled uniformly.
 class ThriftMessageBase {
 public:
-    virtual ~ThriftMessageBase() {};
+    virtual ~ThriftMessageBase() {}
     virtual uint32_t Read(::apache::thrift::protocol::TProtocol* iprot) = 0;
     virtual uint32_t Write(::apache::thrift::protocol::TProtocol* oprot) const = 0;
 };

diff --git a/src/bvar/recorder.h b/src/bvar/recorder.h
@@ -31,7 +31,7 @@
 namespace bvar {
 
 struct Stat {
-    Stat() : sum(0), num(0) {};
+    Stat() : sum(0), num(0) {}
     Stat(int64_t sum2, int64_t num2) : sum(sum2), num(num2) {}
     int64_t sum;
     int64_t num;

diff --git a/tools/rpc_view/rpc_view.cpp b/tools/rpc_view/rpc_view.cpp
@@ -67,7 +67,7 @@ static void handle_response(brpc::Controller* client_cntl,
 class ViewServiceImpl : public ViewService {
 public:
     ViewServiceImpl() {}
-    virtual ~ViewServiceImpl() {};
+    virtual ~ViewServiceImpl() {}
     virtual void default_method(google::protobuf::RpcController* cntl_base,
                                 const HttpRequest*,
                                 HttpResponse*,

diff --git a/tools/trackme_server/trackme_server.cpp b/tools/trackme_server/trackme_server.cpp
@@ -60,7 +60,7 @@ class TrackMeServiceImpl : public brpc::TrackMeService {
 public:
     explicit TrackMeServiceImpl(BugsLoader* bugs) : _bugs(bugs) {
     }
-    ~TrackMeServiceImpl() {};
+    ~TrackMeServiceImpl() {}
     void TrackMe(google::protobuf::RpcController* cntl_base,
                  const brpc::TrackMeRequest* request,
                  brpc::TrackMeResponse* response,