Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cpu overhead when using rdma #2100

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Reduce cpu overhead when using rdma #2100

merged 5 commits into from
Jan 30, 2023

Conversation

Tuvie
Copy link
Contributor

@Tuvie Tuvie commented Jan 28, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

  1. In performance test, using rdma may cost more cpu than TCP because of more bthreads.
  2. In a very rare case, the ibv_post_send operation may fail because of full SQ.

What is changed and the side effects?

Changed:

  1. Reduce the bthread_flush called.
  2. Introduce redundant SQ size to avoid SQ overflow caused by unsignaled WQE.

Side effects:

  • Performance effects(性能影响): CPU overhead will be reduced in rdma_performance.

  • Breaking backward compatibility(向后兼容性): None


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm wwbmmm merged commit 7ae916d into apache:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants