Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure we can receive at least one request #2106

Conversation

yanglimingcn
Copy link
Contributor

极端情况下average latency可能会大于请求的timeout,校验在currency_concurrency是1的时候可以通过,这样能保证在average latency大于请求的timeout的情况下,至少有一个请求可以被处理,这样average latency才能得到更新。

@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 31, 2023

极端情况下average latency可能会大于请求的timeout,校验在currency_concurrency是1的时候可以通过,这样能保证在average latency大于请求的timeout的情况下,至少有一个请求可以被处理,这样average latency才能得到更新。

注释里说明一下?

@yanglimingcn yanglimingcn force-pushed the feature/timeout_concurrency_limiter_add_max_concurrency branch from e4603d6 to 6b4239a Compare February 1, 2023 02:30
@yanglimingcn
Copy link
Contributor Author

yanglimingcn commented Feb 1, 2023

极端情况下average latency可能会大于请求的timeout,校验在currency_concurrency是1的时候可以通过,这样能保证在average latency大于请求的timeout的情况下,至少有一个请求可以被处理,这样average latency才能得到更新。

注释里说明一下?

done

@yanglimingcn yanglimingcn force-pushed the feature/timeout_concurrency_limiter_add_max_concurrency branch from 6b4239a to 11ca28b Compare February 1, 2023 10:59
@wwbmmm
Copy link
Contributor

wwbmmm commented Feb 2, 2023

极端情况下average latency可能会大于请求的timeout,校验在currency_concurrency是1的时候可以通过,这样能保证在average latency大于请求的timeout的情况下,至少有一个请求可以被处理,这样average latency才能得到更新。

注释里说明一下?

done

没有看到注释呢

…imeout, allow currency_concurrency is 1 ensures the average latency can be obtained renew.
@yanglimingcn yanglimingcn force-pushed the feature/timeout_concurrency_limiter_add_max_concurrency branch from 11ca28b to 4eee48c Compare February 2, 2023 09:12
@yanglimingcn
Copy link
Contributor Author

极端情况下average latency可能会大于请求的timeout,校验在currency_concurrency是1的时候可以通过,这样能保证在average latency大于请求的timeout的情况下,至少有一个请求可以被处理,这样average latency才能得到更新。

注释里说明一下?

done

没有看到注释呢

我理解错了,我写到commit的comment里面了。done

@wwbmmm wwbmmm merged commit 02ec31d into apache:master Feb 6, 2023
@yanglimingcn
Copy link
Contributor Author

现在这个算法是通过gflags统一设置了FLAGS_timeout_cl_max_concurrency、FLAGS_timeout_cl_default_timeout_ms,如果想要为不同method设置不同的值,有啥办法吗? @wwbmmm

@wwbmmm
Copy link
Contributor

wwbmmm commented Feb 7, 2023

现在这个算法是通过gflags统一设置了FLAGS_timeout_cl_max_concurrency、FLAGS_timeout_cl_default_timeout_ms,如果想要为不同method设置不同的值,有啥办法吗? @wwbmmm

可以考虑扩展下AdaptiveMaxConcurrency,增加更多的参数

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants