Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different method can use different TimeoutConcurrencyConf #2112

Conversation

yanglimingcn
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Feb 9, 2023

建议补充对应单测

@yanglimingcn yanglimingcn force-pushed the feature/timeout_concurrency_limiter_add_max_concurrency branch from a944600 to 019ed6e Compare February 10, 2023 09:14
@yanglimingcn
Copy link
Contributor Author

done

@yanglimingcn yanglimingcn force-pushed the feature/timeout_concurrency_limiter_add_max_concurrency branch from 019ed6e to b149783 Compare February 13, 2023 07:34
@wwbmmm
Copy link
Contributor

wwbmmm commented Feb 13, 2023

LGTM

@wwbmmm wwbmmm merged commit 9961be7 into apache:master Mar 10, 2023
yanglimingcn added a commit to yanglimingcn/brpc that referenced this pull request Jun 25, 2023
yanglimingcn added a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants