Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support user fields of baidu protocol #2406

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Support user fields of baidu protocol #2406

merged 2 commits into from
Dec 20, 2023

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Oct 9, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: #2405、#1479

Problem Summary:

支持用户在请求或者响应中添加一些通用属性，无需修改上层协议。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright mentioned this pull request Oct 9, 2023
Open
@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 13, 2023

LGTM

@chenBright chenBright added the feature new feature label Oct 13, 2023
@yanglimingcn
Copy link
Contributor

现在baidu_std协议如果请求处理失败了，应答包就不会pack用户的response了，这个pr是不是可以做到在请求处理失败，也可以设置应答属性字段。

@wwbmmm wwbmmm merged commit 2098dd3 into apache:master Dec 20, 2023
16 checks passed
@chenBright chenBright deleted the user_fields branch December 20, 2023 07:05
@chenBright
Copy link
Contributor Author

现在baidu_std协议如果请求处理失败了，应答包就不会pack用户的response了，这个pr是不是可以做到在请求处理失败，也可以设置应答属性字段。

这应该是另一个特性吧，支持请求处理失败的回调函数。

@wasphin wasphin mentioned this pull request Mar 13, 2024
Closed
@wwbmmm wwbmmm mentioned this pull request Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyearn zyearn zyearn left review comments

Assignees
No one assigned
Labels
feature new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenBright @wwbmmm @yanglimingcn @zyearn