Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix window update threshold #2418

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix window update threshold #2418

merged 1 commit into from
Dec 14, 2023

Conversation

jiangyt-git
Copy link
Contributor

@jiangyt-git jiangyt-git commented Oct 19, 2023 •
edited by wwbmmm
Loading

What problem does this PR solve?

Issue Number:
#1597
Problem Summary:
修复issue #1597中的case: grpc 并发加限流可能会造成的死锁风险

What is changed and the side effects?

Changed:
使用并发量而不是固定值来确定_deferred_window_update的阈值，将quota分配给单stream。

Side effects:

  • Performance effects(性能影响):
    window_update frame 会随着并发量级而增多。
  • Breaking backward compatibility(向后兼容性):
    No

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@jiangyt-git
Copy link
Contributor Author

@ehds @wwbmmm

@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 25, 2023

LGTM

@jiangyt-git
Copy link
Contributor Author

@chenBright @zyearn

@chenBright
Copy link
Contributor

LGTM

@wwbmmm wwbmmm merged commit 249df0f into apache:master Dec 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangyt-git @wwbmmm @chenBright