Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Content-Length header of GET request #2458

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Remove Content-Length header of GET request #2458

merged 1 commit into from
Dec 3, 2023

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Nov 26, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number:

Problem Summary:

Get请求带上了Content-Lenght > 0 的header，服务端会一直在等body数据，直到客户端rpc超时。所以，需要移除Get请求中的Content-Lenght header。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright changed the title Remove Expect header and Content-Length header Remove Content-Length header of GET request Nov 26, 2023
@wwbmmm
Copy link
Contributor

wwbmmm commented Nov 27, 2023

LGTM

@zyearn zyearn merged commit 308b3c8 into apache:master Dec 3, 2023
18 checks passed
@chenBright chenBright deleted the fix_get_content_length branch December 4, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenBright @wwbmmm @zyearn