Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt contention: support tcmalloc GetStackTrace and reduce hash calculations #2488

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary: SampledContention的哈希值只需要计算一次。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 9, 2024

LGTM

@chenBright chenBright changed the title Reduce hash calculations of SampledContention Opt contention: support tcmalloc GetStackTrace and reduce hash calculations Jan 11, 2024
@chenBright
Copy link
Contributor Author

tcmalloc GetStackTrace的性能优于glibc backtrace的。当链接了tcmalloc时,优先使用tcmalloc GetStackTrace。

@wwbmmm wwbmmm merged commit 09141d4 into apache:master Jan 17, 2024
18 checks passed
@chenBright chenBright deleted the opt_contention branch January 17, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants