Fix Content-Length and Transfer-Encoding problems #2518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
RFC 7230 3.3.3规范:Content-Length和Transfer-Encoding: chunked不能一起使用,或者忽略Content-Length。目前brpc使用的http-parser版本比较旧,允许Content-Length和Transfer-Encoding: chunked一起使用,存在请求走私(Request Smuggling)和响应拆分(response splitting)的风险。
RFC 7233 3.3.2规范:有Transfer-Encoding的时候,发送者不能发送Content-Length。
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: