Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel callback may be called twice #2557

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

当bthread_id_create执行成功,Socket::Address执行失败是,callback会被执行。当Controller析构的时候,bthread_id_error会再次执行callback。如果callback执行完会被释放(brpc::NewCallback默认行为),那么这个场景下会出现double delete的问题。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Contributor

wwbmmm commented Mar 11, 2024

LGTM

@serverglen serverglen merged commit 17a200c into apache:master Mar 12, 2024
18 checks passed
@chenBright chenBright deleted the fix_notify_on_cancel branch March 12, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants