[feat] latency scale factor #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2024 15:45
wwbmmm
reviewed
Jun 3, 2024
src/brpc/server.cpp
Outdated
| @@ -123,6 +123,8 @@ const int INITIAL_CERT_MAP = 64; | |||
| // compilation units is undefined. | |||
| const int s_ncore = sysconf(_SC_NPROCESSORS_ONLN); | |||
|
|
|||
| DEFINE_uint64(latency_scale_factor, 1, "latency scale factor, used by method status, etc., latency_us = latency * latency_scale_factor"); | |||
There was a problem hiding this comment.
I think this gflag can be directly defined in latency_recorder.cpp, so that it doesn't need to be passed through so many layers of parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary: brpc's latency dispaly is displayed as
us, while in our prod env,msis more meaningful.What is changed and the side effects?
Changed: provide a gflag to change latency's scale factor
Side effects:
Performance effects(性能影响): Little or none
Breaking backward compatibility(向后兼容性): No
Check List: