-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-5748] Upgrade guava from 31.1-jre to 32.0.0-jre #3240
Conversation
… CheckReturnValue check
Kudos, SonarCloud Quality Gate passed! |
@SuppressWarnings("Guava") | ||
@Deprecated // to be removed before 2.0 | ||
public <T, R> Closeable addThread( | ||
final com.google.common.base.Function<T, R> handler) { | ||
return addThread((Consumer<T>) handler::apply); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With guava 32 it starts failing on errorprone checks with CheckReturnValue
Since it is already deprecated with a comment what to use instead probably it makes sense to remove it
// CHECKSTYLE: IGNORE 1 | ||
/** @deprecated Use {@link #queryContains(Consumer)}. */ | ||
@SuppressWarnings("Guava") | ||
@Deprecated // to be removed before 2.0 | ||
public final AssertQuery queryContains( | ||
com.google.common.base.Function<List, Void> predicate1) { | ||
return queryContains((Consumer<List>) predicate1::apply); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With guava 32 it starts failing on errorprone checks with CheckReturnValue
Since it is already deprecated with a comment what to use instead probably it makes sense to remove it
8a5cf83
to
cf7f71b
Compare
closing, since the issue was solved in later guava versions |
regarding NPE on Windows it is just a consequence...
the real reason is fixing of CVE-2020-8908 on guava level[1] and as a result Files#createTempDir stopped working on Windows
I raised an issue for that [2]
Files#createTempDir is used inside embedded redis server and that's why it started to fail on Windows.
The most distracting thing is that this redis embedded server from one side looks not supported since 2018 and from the other side is not easily extensible...
For that reason need to reimplement 3 classes in PR to override behavior
[1] google/guava@feb83a1
[2] google/guava#6535