-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support camel 3.0.0 M3 #79 #81
Support camel 3.0.0 M3 #79 #81
Conversation
aeb320c
to
1abe55b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
import java.util.List; | ||
import java.util.Properties; | ||
|
||
import org.apache.camel.CamelContext; | ||
import org.apache.camel.Ordered; | ||
import org.apache.camel.component.properties.PropertiesComponent; | ||
import org.apache.camel.impl.DefaultCamelContext; | ||
import org.apache.camel.impl.ExplicitCamelContextNameStrategy; | ||
import org.apache.camel.impl.engine.ExplicitCamelContextNameStrategy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need this one for being able to set the name easily, then the setName api is now public. But I think this may be from M4 onwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, will clean up once M4 will be out out
} | ||
|
||
public static int bindProperties(Properties properties, Object target, String prefix) { | ||
public static int bindProperties(CamelContext context, Properties properties, Object target, String prefix) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could likely add API on PropertyBindingSupport to support prefix so we have it OOTB, fell free to log a JIRA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I'm working on this
…pache#81) PNC build is failing because it is trying to use a productized version
No description provided.