chore(deps): Bump dependency versions #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christophd
commented
Jun 28, 2022
christophd
commented
- Jackson v2.13.3
- Logback v1.2.11
- Logstash logback encoder v7.2
- Jackson v2.13.3 - Logback v1.2.11 - Logstash logback encoder v7.2
tadayosi
reviewed
Jun 28, 2022
| <jackson-databind-version>2.9.10.8</jackson-databind-version> | ||
| <logback-version>1.2.11</logback-version> | ||
| <logstash-logback-version>7.2</logstash-logback-version> | ||
| <jackson-version>2.13.3</jackson-version> |
There was a problem hiding this comment.
jackson-core and jackson-databind versions might differ. Is it really ok to combine them?
There was a problem hiding this comment.
I think in general these two should align. There have been quick fixes to jackson-databind in the past that made versions diverge but I think this should not be the usual case.
There was a problem hiding this comment.
@davsclaus @lburgazzoli WDYT?
There was a problem hiding this comment.
LGTM, we can add a dedicate property when/if it is really needed
squakez
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.