chore(build): Use Camel K runtime Maven structural logging module #3376

christophd · 2022-06-20T07:27:08Z

Load and extract structural logging artifacts from Camel K runtime module
Use logback configuration provided by this runtime module
Add logging artifacts during Dockerfile image build

IMPORTANT: This PR must wait for Camel K runtime module to be merged and released to Maven central (apache/camel-k-runtime#833) otherwise build scripts will fail because of the missing module.

As a workaround users can explicitly build the Camel K runtime modules locally and reference the SNAPSHOT version as follows:

make RUNTIME_VERSION=1.14.0-SNAPSHOT images

or use the local Camel K runtime repository

make CAMEL_K_RUNTIME_DIR=$(pwd)/../camel-k-runtime images

This will build the Camel K image with the SNAPSHOT runtime modules and its Maven structural logging settings.

Release Note

Chore(build): Use Camel K runtime Maven structural logging module

christophd · 2022-06-20T07:27:48Z

FYI @squakez

squakez

Nice work!

oscerd · 2022-08-23T04:34:59Z

@christophd can we rebase this? we are now using the next staging release for camel-k-runtime.

christophd · 2022-08-23T07:35:54Z

@oscerd sure will do right now

christophd · 2022-08-23T11:20:30Z

@oscerd I had to add another commit to account for the Camel K staging repository when loading the Camel K runtime Maven logging overlay artifacts

Tried to also retain the functionality to specify a local Camel K runtime codebase to use this instead of loading from the internet.

@squakez @tadayosi can you please also have another look at the changes made?

oscerd · 2022-08-23T11:24:06Z

How do we deal with this if we'll have to release artifacts together? Once we release the runtime the staging repo will go away.. while this is managed for camel k release process, I'm not sure this will be fine for this feature. It could make it unusable

christophd · 2022-08-23T11:29:08Z

not sure but I think we need Camel K runtime to be fully released to maven central before kicking off a release for Camel K right? So we can assume the Camel K runtime bits to always be available on central?

The staging repo support is only for temporary builds like in this PR and should be given as an argument to the Make file call explicitly?

oscerd · 2022-08-23T11:37:07Z

No, the release is done in one shot with the runtime still in staging. If the code remain there during the release we'll have a reference to a repository that doesn't exist. So we should remove it before releasing.

oscerd · 2022-08-23T12:04:40Z

So my suggestion is to remove the staging reference for this specific feature before the release start.

squakez · 2022-08-23T12:34:47Z

I think we should pick the artifacts from staging, when the reference is present, otherwise it must take it from central. Or am I missing something?

oscerd · 2022-08-23T12:41:32Z

During the release, in the beginning there will be some steps using the staging repo, but before the end of the release once the catalog has been generated and the resources generated, the reference to the staging repository will be removed, so in the end there won't any reference to the staging repository and the final artifacts/image etc. The release will take for granted the promotion of the artifacts coming from staging repository to central. In this case, we'll still have reference to the staging repo in the final artifacts and we shouldn't. Hope this makes thing a bit more clear. We are not in the situation in which: k-runtime will be released to central before starting the release of camel-k, the release vote will be one for all the components (camel-kamelets, camel-k-runtime and camel-k): for camel-kamelets we are pointing a tag, so no problem, for k-runtime we are managaing the problem through Makefile subsequent steps, for this overlay feature we are not managing the switching from staging to central at all.

christophd · 2022-08-23T12:52:43Z

@oscerd so it basically follows the steps described in here, right?: https://github.com/apache/camel-k/blob/main/release.adoc

oscerd · 2022-08-23T12:56:31Z

Yes

christophd · 2022-08-23T14:06:58Z

@oscerd so in this process when calling make release-staging the Camel K runtime staging repository is still available, right? I think this is all we need to reference the Maven overlay artifacts in order to add these to the resulting Camel K Docker image that gets pushed to the staging account.

Would that be ok?

oscerd · 2022-08-23T14:14:30Z

The staging repository si be available until the release vote ends, so it will be there until the release passed. But the reference will be removed in next steps of releasing

christophd · 2022-08-23T17:06:10Z

From my understanding the maven-overlay is only used to build the Docker image. Once this is done via make release-staging and the reference to staging gets removed the release process should not build the image once again. I think we are fine with that are we?

oscerd · 2022-08-24T04:47:25Z

I think so.

tadayosi

Only small cosmetic issues.

tadayosi · 2022-08-24T05:16:03Z

script/maven_overlay.sh

+rootdir=$(realpath ${location}/../)
+
+if [ "$#" -lt 2 ]; then
+  echo "usage: $0 <output directory> <Camel K runtime version> [<staging repository>] [<local Camel K runtime project directory>]"


it's a small issue but the usage message doesn't match the actual code. Here <output directory> comes first but actually it should be $2 arg.

Maybe I guess the usage message is the intended one and the code output_dir=$2 is wrong? Is it really meant to be :

output_dir=$1 runtime_version=$2

?

yes, the usage message is wrong. many thanks!

tadayosi · 2022-08-24T05:20:36Z

script/maven_overlay.sh

+
+if [ -n "$staging_repo" ]; then
+    if  [[ $staging_repo == http:* ]] || [[ $staging_repo == https:* ]]; then
+        echo "<settings xmlns=\"http://maven.apache.org/SETTINGS/1.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"" \


I'd use bash heredocument to avoid \ at the end of lines but maybe it's a matter of taste.

cat <<EOF > ${rootdir}/settings.xml ... EOF

good point. thx!

tadayosi · 2022-08-24T05:35:37Z

@oscerd Not this time but IMO in the future we should separate the releasing process of Camel K runtime from the rest of Camel K and release the runtime more frequently because of #3481 to let the runtime catch up with latest LTS releases of Camel / Camel Quarkus. We can vote each release separately.

If I'm not mistaken architecturally Camel K and Camel K runtime are designed to be decoupled so I think it's even encouraged to do so.

oscerd · 2022-08-24T05:37:58Z

We can do that, but instead of taking 72 hours to release, it would take up to one week if everything goes well, if not, maybe more. I don't have particular point of view on this kind of stuff, but camel-k-runtime doesn't have any reason to live without camel-k, so, releasing and voting it as standalone project doesn't make sense.

oscerd · 2022-08-24T05:40:45Z

Please note that the staging repo is now https://repository.apache.org/content/repositories/orgapachecamel-1460/ and not https://repository.apache.org/content/repositories/orgapachecamel-1459/

tadayosi · 2022-08-24T05:45:12Z

but camel-k-runtime doesn't have any reason to live without camel-k

Yes, right, but my point is that if we release camel-k-runtime separately users could serve themselves for upgrading the runtime to a more secure one if they are concerned with any CVEs. Right now they have to wait for a main Camel K release to receive the latest patches for the runtime.

oscerd · 2022-08-24T05:47:53Z

In the last release of camel-k-runtime we just released because of camel-k, but yeah, if there is security concern or CVE to fix we could release it alone.

- Load and extract structural logging artifacts from Camel K runtime module - Use logback configuration provided by this runtime module - Add logging artifacts during Dockerfile image build

…ay artifacts

christophd · 2022-08-24T11:12:46Z

removed the WIP marker as this is ready to be merged IMO

christophd mentioned this pull request Jun 20, 2022

Add new module for structural Maven logging apache/camel-k-runtime#833

Merged

tadayosi approved these changes Jun 20, 2022

View reviewed changes

squakez approved these changes Jun 20, 2022

View reviewed changes

squakez added the status/wip Work in progress label Jun 20, 2022

squakez added this to the 1.10.0 milestone Jun 20, 2022

tadayosi mentioned this pull request Aug 22, 2022

1.10.0 Release #3560

Closed

christophd force-pushed the pr/maven-overlay branch from 118b825 to b3decac Compare August 23, 2022 07:37

christophd force-pushed the pr/maven-overlay branch from 5f9ec6f to 692f427 Compare August 23, 2022 13:48

tadayosi removed the status/wip Work in progress label Aug 24, 2022

tadayosi reviewed Aug 24, 2022

View reviewed changes

chore(build): Use Camel K runtime Maven structural logging module

627d943

- Load and extract structural logging artifacts from Camel K runtime module - Use logback configuration provided by this runtime module - Add logging artifacts during Dockerfile image build

christophd force-pushed the pr/maven-overlay branch from 692f427 to 7363016 Compare August 24, 2022 06:35

chore(build): Account for staging repository when loading Maven overl…

2919a24

…ay artifacts

christophd force-pushed the pr/maven-overlay branch from 7363016 to 2919a24 Compare August 24, 2022 11:11

christophd changed the title ~~[WIP] chore(build): Use Camel K runtime Maven structural logging module~~ chore(build): Use Camel K runtime Maven structural logging module Aug 24, 2022

oscerd merged commit 753da06 into apache:main Aug 24, 2022

squakez mentioned this pull request Oct 31, 2023

Fix SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder" #4883

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(build): Use Camel K runtime Maven structural logging module #3376

chore(build): Use Camel K runtime Maven structural logging module #3376

christophd commented Jun 20, 2022

christophd commented Jun 20, 2022

squakez left a comment

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

oscerd commented Aug 23, 2022

squakez commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 24, 2022

tadayosi left a comment

tadayosi Aug 24, 2022

christophd Aug 24, 2022

tadayosi Aug 24, 2022

christophd Aug 24, 2022

tadayosi commented Aug 24, 2022

oscerd commented Aug 24, 2022

oscerd commented Aug 24, 2022

tadayosi commented Aug 24, 2022

oscerd commented Aug 24, 2022

christophd commented Aug 24, 2022

chore(build): Use Camel K runtime Maven structural logging module #3376

chore(build): Use Camel K runtime Maven structural logging module #3376

Conversation

christophd commented Jun 20, 2022

christophd commented Jun 20, 2022

squakez left a comment

Choose a reason for hiding this comment

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

oscerd commented Aug 23, 2022

squakez commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 23, 2022

christophd commented Aug 23, 2022

oscerd commented Aug 24, 2022

tadayosi left a comment

Choose a reason for hiding this comment

tadayosi Aug 24, 2022

Choose a reason for hiding this comment

christophd Aug 24, 2022

Choose a reason for hiding this comment

tadayosi Aug 24, 2022

Choose a reason for hiding this comment

christophd Aug 24, 2022

Choose a reason for hiding this comment

tadayosi commented Aug 24, 2022

oscerd commented Aug 24, 2022

oscerd commented Aug 24, 2022

tadayosi commented Aug 24, 2022

oscerd commented Aug 24, 2022

christophd commented Aug 24, 2022