Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trait): let camel framework manage Kamelets #4797

Closed
wants to merge 4 commits into from

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Oct 5, 2023

With this PR we get rid off the very first Kamelets runtime execution which translated the Kamelets into a route templates. We let now the Camel runtime to use the Kamelets as they are expected in the framework.

Closes #4618

Release Note

feat(trait): let camel framework manage Kamelets 

We use the mechanism expected by Camel runtime framework to manage Kamelets at runtime
@squakez squakez added the kind/feature New feature or request label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.3% --> 33.2% (Coverage difference: -.1%)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.4% --> 33.3% (Coverage difference: -.1%)

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.4% --> 33.3% (Coverage difference: -.1%)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.4% --> 33.3% (Coverage difference: -.1%)

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.4% --> 33.3% (Coverage difference: -.1%)

@squakez
Copy link
Contributor Author

squakez commented Oct 6, 2023

@christophd the Yaks check is failing because we need to provide the dependencies when creating a Kamelet. Is there any way to do that easily in

Given create Kamelet no-props-source with flow
- I guess it won't just work by adding the dependencies parameter, is it?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.4% --> 33.3% (Coverage difference: -.1%)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.4% --> 33.3% (Coverage difference: -.1%)

@christophd
Copy link
Contributor

@christophd the Yaks check is failing because we need to provide the dependencies when creating a Kamelet. Is there any way to do that easily in

Given create Kamelet no-props-source with flow

  • I guess it won't just work by adding the dependencies parameter, is it?

I think there is a way to also add dependencies to the YAKS step. But maybe it is better to not use Given create Kamelet no-props-source with flow step and just add this Kamelets via YAML file as you did. I think I am ok with that.

@christophd
Copy link
Contributor

I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are there any other side effects of this?

@squakez
Copy link
Contributor Author

squakez commented Oct 9, 2023

I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are there any other side effects of this?

Yes, this is a valid point, thanks. I overlooked this part as we miss any test validating such feature. We need, at least, to parse the inner logic of kamelets in order to discover "capabilities" of any sort beside dependencies. I'll see how we can include this as well and include a test in order to validate the feature.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.4% --> 33.3% (Coverage difference: -.1%)

@squakez
Copy link
Contributor Author

squakez commented Oct 10, 2023

I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are there any other side effects of this?

Yes, this is a valid point, thanks. I overlooked this part as we miss any test validating such feature. We need, at least, to parse the inner logic of kamelets in order to discover "capabilities" of any sort beside dependencies. I'll see how we can include this as well and include a test in order to validate the feature.

Parsing is now done in #4812 which supersedes this PR. Basically we maintain the generated source in order to perform any parsing as we used to do, but, we do not mount such sources. We instead create a Kamelet bundle configmap which is mounted under ''/etc/camel/kamelets` and let the runtime to use such Kamelets as it normally does in plain Camel.

@squakez squakez closed this Oct 10, 2023
@squakez squakez deleted the feat/4618_cm branch October 10, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
2 participants