Builder annotation support #5104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am struggling to find any place to insert test for this enhancement. Could anyone chime in? |
squakez
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Please, open separate PRs in order to discuss each different topic separately. Regarding this specific feature, LGTM. For testing, please, have a look at this example:
camel-k/pkg/trait/builder_test.go
Line 466 in 1db0f57
|
✔️ Unit test coverage report - coverage increased from 34.8% to 35.3% (+0.5%) |
rodcloutier
force-pushed
the
builder-annotation-support
branch
from
f194d9a
to
477d438
Compare
|
✔️ Unit test coverage report - coverage increased from 34.8% to 35.3% (+0.5%) |
squakez
approved these changes
Jan 26, 2024
|
✔️ Unit test coverage report - coverage increased from 34.8% to 35.6% (+0.8%) |
gansheer
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add the possibility to configure annotation on the build pod.
This was required to allow build pods to properly execute in the context of using Buildah in an AppArmor enabled Kubernetes cluster.
Also included are a few tweak encountered while running the operator out of cluster.
Release Note
Fixes #5106