New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4948 part of #3397 #5119

Closed

valdar wants to merge 2 commits into apache:main from valdar:issue/3397

Member

valdar commented Jan 29, 2024

Fix for #4948 that is part of #3397

A platformcontroller command is added as subcommand of kamel; it runs an operator like the operator subcomand does, but platformcontroller would just handle IntegrationPlatform CRs. All the other CRDs are handled by operator as before.

These installation methods have been amended accordingly:

install command
olm bundle
helm charts

e2e tests has been ran locally as well.

Release Note

NONE

valdar added the kind/feature label

gansheer reviewed

View reviewed changes

config/manager/platformcontroller-deployment.yaml Outdated Show resolved Hide resolved

gansheer reviewed

View reviewed changes

config/manager/platformcontroller-deployment.yaml Outdated Show resolved Hide resolved

gansheer reviewed

View reviewed changes

config/manager/platformcontroller-deployment.yaml Outdated Show resolved Hide resolved

valdar mentioned this pull request

fix(github actions): Made some checks on pod names more specific to a… #5123

Merged

valdar force-pushed the issue/3397 branch 5 times, most recently from 5be3431 to 15b484a Compare

January 31, 2024 11:11

squakez reviewed

View reviewed changes

Contributor

squakez left a comment

The main concern I have is about code duplication (maintainability) and performance loss. About the first, I think it would be a matter of abstracting the code from the operator and be able to call it from different places.

About performances I guess it's a bit more complicated. IIUC, so far we're having two separate Pods with 2 separate caches. I honestly don't think that the platform controller has to watch at any resource at all, but only owns the IntegrationPlatform resource. If it requires to watch all those resources for any reason, then, we should understand if we can share the cache somehow.

Additionally, I wonder if instead of having a new deployment, we can simply have a sidecar container to take care of controlling this part.

pkg/cmd/platformcontroller/platformcontroller.go Show resolved Hide resolved

valdar mentioned this pull request

fix(github actions): restircted image-pull-policy-always patch apply … #5128

Merged

valdar force-pushed the issue/3397 branch from 15b484a to 28a15aa Compare

February 2, 2024 10:01

Member Author

valdar commented Feb 3, 2024 •

edited

Loading

What about these tests:

❌ TestMetrics (3m0.27s)
❌ TestMetrics/reconciliation_duration_metric (10ms)

they seems flaky to me, first run they were passing, they are passing locally, but now failing in CI :/

They are also marked as "problematic" but CI runs without the skip problematic config? :/

Contributor

squakez commented Feb 5, 2024

What about these tests:

❌ TestMetrics (3m0.27s) ❌ TestMetrics/reconciliation_duration_metric (10ms)

they seems flaky to me, first run they were passing, they are passing locally, but now failing in CI :/

They are also marked as "problematic" but CI runs without the skip problematic config? :/

No, I don't think they are flaky. It fails at line:

Expect(platformReconciled).NotTo(BeNil())

I suspect that the operator perform and provide metrics which we may have lost if running the reconciliation loop outside the main process.

valdar force-pushed the issue/3397 branch 4 times, most recently from 7cfce32 to 82e6c57 Compare

February 15, 2024 21:21

Contributor

github-actions bot commented Feb 15, 2024

⚠️ Unit test coverage report - coverage decreased from 35.8% to 35.7% (-0.1%)

1 similar comment

Contributor

github-actions bot commented Feb 15, 2024

⚠️ Unit test coverage report - coverage decreased from 35.8% to 35.7% (-0.1%)

Contributor

lburgazzoli commented Feb 27, 2024

@valdar @rinaldodev mind rebasing ?

valdar force-pushed the issue/3397 branch from 253ce80 to f20f818 Compare

February 27, 2024 13:34

lburgazzoli mentioned this pull request

fix(#5097): Remove secondary IntegrationPlatform in favor of using IntegrationProfile #5138

Merged

lburgazzoli reviewed

View reviewed changes

build/test.log Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

pkg/cmd/manager/controller.go Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

pkg/cmd/manager/controller.go Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

pkg/cmd/manager/controller.go Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

pkg/cmd/manager/controller.go Outdated Show resolved Hide resolved

lburgazzoli reviewed

View reviewed changes

pkg/cmd/manager/controller.go Outdated Show resolved Hide resolved

Contributor

squakez commented Mar 20, 2024

@valdar please rebase against main again. The Quarkus native checks have been fixed, so you won't need to run them manually any longer. Thanks.

valdar force-pushed the issue/3397 branch from 3d0a708 to ac00dd5 Compare

March 20, 2024 10:39

Contributor

github-actions bot commented Mar 20, 2024

⚠️ Unit test coverage report - coverage decreased from 37.3% to 37.2% (-0.1%)

Contributor

github-actions bot commented Apr 9, 2024

⚠️ Unit test coverage report - coverage decreased from 37.8% to 37.7% (-0.1%)

valdar force-pushed the issue/3397 branch from 77fe3b2 to 930bae3 Compare

April 11, 2024 14:47

Contributor

github-actions bot commented Apr 11, 2024

⚠️ Unit test coverage report - coverage decreased from 37.8% to 37.7% (-0.1%)

valdar force-pushed the issue/3397 branch 2 times, most recently from 9460bec to 046ed3e Compare

April 16, 2024 10:34

Contributor

github-actions bot commented Apr 16, 2024

⚠️ Unit test coverage report - coverage decreased from 38% to 37.9% (-0.1%)

valdar force-pushed the issue/3397 branch from 046ed3e to 4dd75a8 Compare

April 16, 2024 15:55

Contributor

github-actions bot commented Apr 16, 2024

⚠️ Unit test coverage report - coverage decreased from 38% to 37.9% (-0.1%)

valdar force-pushed the issue/3397 branch from 4dd75a8 to 12c862f Compare

April 17, 2024 11:30

Contributor

github-actions bot commented Apr 17, 2024

⚠️ Unit test coverage report - coverage decreased from 38% to 37.9% (-0.1%)

valdar force-pushed the issue/3397 branch from 12c862f to 3e18ee4 Compare

April 17, 2024 13:03

Contributor

github-actions bot commented Apr 17, 2024

⚠️ Unit test coverage report - coverage decreased from 38% to 37.9% (-0.1%)

valdar force-pushed the issue/3397 branch from 3e18ee4 to 520b593 Compare

April 18, 2024 17:06

Contributor

github-actions bot commented Apr 18, 2024

⚠️ Unit test coverage report - coverage decreased from 38% to 37.9% (-0.1%)

valdar force-pushed the issue/3397 branch 2 times, most recently from fb907a5 to 4457b27 Compare

April 23, 2024 08:48

Contributor

github-actions bot commented Apr 23, 2024

⚠️ Unit test coverage report - coverage decreased from 38% to 37.9% (-0.1%)

lburgazzoli mentioned this pull request

fix(trait): define synthetic Kit #5399

Merged

valdar mentioned this pull request

Test fixes #5415

Merged

valdar force-pushed the issue/3397 branch 2 times, most recently from 283699e to f77f281 Compare

May 13, 2024 14:59

valdar added 2 commits

May 13, 2024 17:22


          fix(apache#4948): Move handling of IntegrationPlatform CR to a separa…

e5f4ae5

…te operator.

Add a separate platformcontroller subcommand to kamel, amend install command and other installations (OLM, kustomize, helm) as needed.
The platformcontroller works as the operator command but runs an operator that handles just the IntegrationPlatform crd;
the operator dose not manage IntegrationPlatform crd any more.


          fix(apache#4948): Refactor common logic between operator and platform…

…controller

valdar force-pushed the issue/3397 branch from f77f281 to 0901791 Compare

May 13, 2024 15:24

valdar mentioned this pull request

Issue/3397 #5701

Open

Member Author

valdar commented Jul 23, 2024

This work has been moved to a branch under camel-k project: https://github.com/apache/camel-k/tree/issue/3397 and another PR has been opened #5701

valdar closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature trigger native test