-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement add classifier field to the MavenArtifact struct #5126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things to review. I'd avoid to change the jolokia until the new parameters are on the catalog (the final agent text will have more changes I think). However, the usage of classifier is something we should already provide.
db5281b
to
2abad36
Compare
2abad36
to
421de11
Compare
Classifier: "foo", | ||
Version: "1.2", | ||
} | ||
assert.Equal(t, "mvn:org.mygroup:my-artifact::foo:1.2", a5.GetDependencyID()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ::
looks suspicious. Are they really expected that way?
421de11
to
d0f0943
Compare
✔️ Unit test coverage report - coverage increased from 35.6% to 35.7% (+0.1%) |
d0f0943
to
7c2b5bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey, if I understand correctly, the regex still would expect in parameters such as type
and classifier
, and, is that case provides empty value ending up with a format like org.mygroup:my-artifact:::foo
. Considering this is only used internally, I think it's good to go.
Originally the |
The classifier is relevant, since jolokia 2.0.0 jvm agent is resolved by using a GAV classifier.
The change in camel-k-catalog is in this PR #1161
Release Note