Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(knative): configure via properties #5186

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore(knative): configure via properties #5186

merged 1 commit into from
Feb 27, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Feb 27, 2024

With this PR we move the configuration from the env var to the properties.

Release Note

chore(knative): configure via properties

@squakez
Copy link
Contributor Author

squakez commented Feb 27, 2024

Part of #5090 - @lburgazzoli please, have a look and confirm if this part is good.

@github-actions GitHub Actions
Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 36% to 36.2% (+0.2%)

lburgazzoli
lburgazzoli reviewed Feb 27, 2024
View reviewed changes
pkg/trait/camel.go Outdated Show resolved Hide resolved
lburgazzoli
lburgazzoli reviewed Feb 27, 2024
View reviewed changes
pkg/trait/camel.go Outdated Show resolved Hide resolved
@squakez
Copy link
Contributor Author

squakez commented Feb 27, 2024

If tests are green and @lburgazzoli is fine with the development, we can merge this.

@github-actions GitHub Actions
Copy link
Contributor

✔️ Unit test coverage report - coverage increased from 36% to 36.2% (+0.2%)

@squakez
Copy link
Contributor Author

squakez commented Feb 27, 2024

Known flaky check failure. Merging.

@squakez squakez merged commit 9c058da into apache:main Feb 27, 2024
14 of 15 checks passed
@squakez squakez deleted the chore/knative_refact branch February 27, 2024 16:52
@lburgazzoli
Copy link
Contributor

do we have an issue to track the flaky test ?

@squakez
Copy link
Contributor Author

squakez commented Feb 27, 2024

do we have an issue to track the flaky test ?

Probably not. This is happening because some sync problem in github actions OS when running the --dev and watching files. We've planned to deprecate the kamel run, so, feel free to log an issue if you think it deserves attention.

@lburgazzoli
Copy link
Contributor

it is more for knowledge sharing so everyone knows why we merged something with failing tests and we can check the issue to be solved when moving to the new architecture

@squakez squakez mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squakez @lburgazzoli